Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: Add ip-src|dst and ip-dst|port as matching attr types to cidr lists #270

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Wachizungu
Copy link
Contributor

@Wachizungu Wachizungu commented Apr 21, 2024

Should be okay but having some issues running validate all /jq all. Please double check if possible.

didn't see a reason why these attribute types are/where not there

@adulau
Copy link
Member

adulau commented Apr 22, 2024

Thanks a lot. But maybe we should review the generator scripts to ensure that won't overwritten at the next update.

@Wachizungu
Copy link
Contributor Author

Updated :), added changes for the relevant generation scripts I could find.

@adulau adulau merged commit fa799e2 into MISP:main Apr 22, 2024
5 checks passed
@adulau
Copy link
Member

adulau commented Apr 22, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants