Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONファイルを差し替えました #24

Merged
merged 1 commit into from
May 29, 2024
Merged

JSONファイルを差し替えました #24

merged 1 commit into from
May 29, 2024

Conversation

nbayashi
Copy link
Contributor

@nbayashi nbayashi commented May 29, 2024

Issue

close #0

変更内容:Description

  • タイトルのとおり
    データセットのリスト表示用のcatalog.jsonを差し替えました

テスト手順:Test

  • データセットに項目が増えていることを確認
    旧版のデータセットリストは以下の画像の通り
image

更新後はこれくらい項目が増える
Group 28

  • 追加されたデータを追加したり詳細ページにきちんと飛べるか確認

その他:Notes

  • 特になし

@nbayashi nbayashi requested a review from bordoray May 29, 2024 06:20
Copy link
Contributor

coderabbitai bot commented May 29, 2024

Important

Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • catalog.json is excluded by !**/*.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tip

Early Access Features
  • gpt-4o model for chat
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@bordoray bordoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

データが増えて確認しました!👌

IMO: 更新方法が変わりましたので、catalog フォルダーにReadmeファイルを作成して「https://data.earth.jaxa.jp/app/qgis/catalog/ にダウンロードしてcatalog.jsonを入れ替えて更新できますよ」とかの内容があればいいと思います。

@nbayashi
Copy link
Contributor Author

データセットの更新方法をREADMEに書くのは賛成です。ただ、catalogフォルダーの中だとわからない人もいると思うので、トップのREADME.mdに書くのではどうでしょうか?

@bordoray
Copy link
Contributor

OKです!

Copy link
Contributor

@bordoray bordoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM_space_cat

@bordoray bordoray merged commit 7b540b4 into master May 29, 2024
2 checks passed
@bordoray bordoray deleted the replace-JSON branch May 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants