Skip to content

Commit

Permalink
Removed tabs + button
Browse files Browse the repository at this point in the history
Issue firefox-devtools#4312
Removed:
- import of formatKeyShortcut
- onclick
- render newButton method
- debugger.properties sourceTabs.newTabButtonTooltip
Kept:
SVG plus icon
  • Loading branch information
Michal Frystacky authored and Michal Frystacky committed Oct 13, 2017
1 parent 8ff3080 commit f64171a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.
4 changes: 0 additions & 4 deletions assets/panel/debugger.properties
Original file line number Diff line number Diff line change
Expand Up @@ -468,10 +468,6 @@ sourceFooter.codeCoverage=Code coverage
# for close tab button in source tabs.
sourceTabs.closeTabButtonTooltip=Close tab

# LOCALIZATION NOTE (sourceTabs.newTabButtonTooltip): The tooltip that is displayed for
# new tab button in source tabs.
sourceTabs.newTabButtonTooltip=Search for sources (%S)

# LOCALIZATION NOTE (scopes.header): Scopes right sidebar pane header.
scopes.header=Scopes

Expand Down
28 changes: 0 additions & 28 deletions src/components/Editor/Tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import CloseButton from "../shared/Button/Close";
import Svg from "../shared/Svg";
import { showMenu, buildMenu } from "devtools-launchpad";
import { debounce } from "lodash";
import { formatKeyShortcut } from "../../utils/text";
import "./Tabs.css";

import PaneToggleButton from "../shared/Button/PaneToggle";
Expand Down Expand Up @@ -91,7 +90,6 @@ class SourceTabs extends PureComponent {
renderTab: Function;
renderSourceTab: Function;
renderSearchTab: Function;
renderNewButton: Function;
renderDropDown: Function;
renderStartPanelToggleButton: Function;
renderEndPanelToggleButton: Function;
Expand Down Expand Up @@ -134,7 +132,6 @@ class SourceTabs extends PureComponent {
this.renderTabs = this.renderTabs.bind(this);
this.renderSourceTab = this.renderSourceTab.bind(this);
this.renderSearchTab = this.renderSearchTab.bind(this);
this.renderNewButton = this.renderNewButton.bind(this);
this.renderDropDown = this.renderDropdown.bind(this);
this.renderStartPanelToggleButton = this.renderStartPanelToggleButton.bind(
this
Expand Down Expand Up @@ -418,30 +415,6 @@ class SourceTabs extends PureComponent {
);
}

renderNewButton() {
const newTabTooltip = L10N.getFormatStr(
"sourceTabs.newTabButtonTooltip",
formatKeyShortcut(L10N.getStr("sources.search.key2"))
);

const onButtonClick = () => {
if (this.props.searchOn) {
return this.props.closeActiveSearch();
}
this.props.setActiveSearch("source");
};

return (
<div
className="new-tab-btn"
onClick={onButtonClick}
title={newTabTooltip}
>
<Svg name="plus" />
</div>
);
}

renderDropdown() {
const hiddenSourceTabs = this.state.hiddenSourceTabs;
if (!hiddenSourceTabs || hiddenSourceTabs.size == 0) {
Expand Down Expand Up @@ -494,7 +467,6 @@ class SourceTabs extends PureComponent {
<div className="source-header">
{this.renderStartPanelToggleButton()}
{this.renderTabs()}
{this.renderNewButton()}
{this.renderDropdown()}
{this.renderEndPanelToggleButton()}
</div>
Expand Down

0 comments on commit f64171a

Please sign in to comment.