Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add reply counts to threads #2109

Merged
merged 7 commits into from
Apr 19, 2024
Merged

feat: Add reply counts to threads #2109

merged 7 commits into from
Apr 19, 2024

Conversation

gmeben
Copy link
Contributor

@gmeben gmeben commented Apr 19, 2024 •
edited
Loading

This pull request:

  • Adds to the "Show/Hide Replies" buttons a count of how many replies a comment thread contains.
  • Bonus
    • Prevents the "Cancel" button from appearing for the overall comment draft form at the bottom of the Submission Review page. Note: this button still appears for the draft form for overall comment replies.
    • Adds a missing property to SubmissionsPage.vitest.spec.js

Closes #2070

@gmeben gmeben requested review from vilagshe and wreality April 19, 2024 13:09
wreality
wreality approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@wreality wreality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gmeben gmeben merged commit 9355d2e into master Apr 19, 2024
17 checks passed
@gmeben gmeben deleted the issue2070-reply-counts branch April 19, 2024 18:51
@wreality wreality mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wreality wreality wreality approved these changes

@vilagshe vilagshe Awaiting requested review from vilagshe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Counts of Replies to Comment Threads
2 participants
@gmeben @wreality