Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS manuscript #693

Merged
merged 20 commits into from
Mar 9, 2021
Merged

JOSS manuscript #693

merged 20 commits into from
Mar 9, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 3, 2021

Closes #669.

To do:

Changes proposed in this pull request:

  • Add JOSS manuscript, in markdown format.
  • Add figure.
  • Add bibliography in BibLaTeX format.

tsalo added 2 commits March 3, 2021 12:00
@tsalo
Copy link
Member Author

tsalo commented Mar 3, 2021

I don't want to run the CI, but including [skip-ci] in my commit message didn't do anything ☹️. Anyone have a solution?

paper/paper.md Outdated Show resolved Hide resolved
@jbteves
Copy link
Collaborator

jbteves commented Mar 3, 2021

I think you want space instead of -

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #693 (9c52f3f) into joss (009ccc5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             joss     #693   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          26       26           
  Lines        2029     2029           
=======================================
  Hits         1900     1900           
  Misses        129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009ccc5...9c52f3f. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented Mar 3, 2021

That seems to have worked. Thanks @jbteves!

paper/paper.md Outdated Show resolved Hide resolved
Co-authored-by: Elizabeth DuPre <[email protected]>
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@handwerkerd
Copy link
Member

In the rendered version of the paper, the first author & title is on the bottom of each page. The title is correct, but the author is Mickey Mouse. I suspect that, wherever the render is pulling that info from is getting confused by the two first authors.
image

@emdupre
Copy link
Member

emdupre commented Mar 4, 2021

In the rendered version of the paper, the first author & title is on the bottom of each page. The title is correct, but the author is Mickey Mouse. I suspect that, wherever the render is pulling that info from is getting confused by the two first authors.

Ah no sorry, this is just the JOSS preview template ! It's also not filling in the year, for example :) You can confirm this by building a preview for PyBIDS, which includes a previously accepted paper.

It will be updated when built by Whedon in the proper submission pipeline.

@notZaki
Copy link
Contributor

notZaki commented Mar 4, 2021

The sub/sup scripts don't look like they're being rendered in the pdf. Maybe because the current syntax is html-specific?

If JOSS uses pandoc, then the following change might work

- T<sub>2</sub><sup>\*</sup>
+ T~2~^\*^

Edit: Or switch to math mode? But that often changes the font and I find that distracting.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my reading, the JOSS submission guidelines ask for non-abbreviated references:

Also note that the references include full names of venues, e.g., journals and conferences, not abbreviations only understood in the context of a specific discipline.

I've made suggestions to that effect ! I've also gone through and changed the UNPUBLISHED biblatex classes to MISC so that we can add and display a DOI, which will almost definitely be requested by Whedon on submission !

paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
Co-authored-by: Elizabeth DuPre <[email protected]>
Co-authored-by: Joshua Teves <[email protected]>
paper/paper.bib Outdated Show resolved Hide resolved
@tsalo
Copy link
Member Author

tsalo commented Mar 4, 2021

The sub/sup scripts don't look like they're being rendered in the pdf. Maybe because the current syntax is html-specific?

If JOSS uses pandoc, then the following change might work

- T<sub>2</sub><sup>\*</sup>
+ T~2~^\*^

Edit: Or switch to math mode? But that often changes the font and I find that distracting.

@notZaki Your recommendation worked! Thanks!

@tsalo
Copy link
Member Author

tsalo commented Mar 4, 2021

@smoia @CesarCaballeroGaudes you noted issues with some of the references, but PaperPile autogenerated them. We can change them now though! Would you mind adding comments about any incorrect references?

@CesarCaballeroGaudes
Copy link
Contributor

CesarCaballeroGaudes commented Mar 4, 2021

Where is the link to the paper? I mean the final version with the references?

@emdupre
Copy link
Member

emdupre commented Mar 4, 2021

Where is the link to the paper? I mean the final version with the references?

You can use: http://whedon.theoj.org
Just put in https://github.com/tsalo/tedana for the repo and joss for the branch.

But it's building automatically from the files in this PR !

@CesarCaballeroGaudes
Copy link
Contributor

CesarCaballeroGaudes commented Mar 4, 2021

Ok, I've checked the current version. I assume @tsalo is referring to my comment about the fact that @smoia paper (Moia, Termenon) has been accepted in Neuroimage, but we don't have DOI number yet (at least at this time of the day). But the biorxiv website will indicate that the paper is accepted. Somehow similar with @jsheunis paper which is under review too.

@CesarCaballeroGaudes
Copy link
Contributor

CesarCaballeroGaudes commented Mar 4, 2021

One suggestion/question: Why are the DOI numbers only included in the biorxiv papers, and not in the others?

@smoia
Copy link
Collaborator

smoia commented Mar 5, 2021

The preview looks good to me! The only thing I find strange (besides the inconsistency of DOIs that César was pointing out) is the inconsistency of the author lists in the bibliography, in which you have fMRI prep list most of its authors and the paper after using "& others". But that's more OCP spasms than anything else, probably.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding DOIs to all article types

paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
@emdupre
Copy link
Member

emdupre commented Mar 6, 2021

Why are the DOI numbers only included in the biorxiv papers, and not in the others?

I had previously only added them under the preprints since I know that they'll be required for cross-checking any unpublished references, but I've made suggestions now to add them for all article classes !

paper/paper.bib Outdated Show resolved Hide resolved
@emdupre
Copy link
Member

emdupre commented Mar 6, 2021

The only thing I find strange (besides the inconsistency of DOIs that César was pointing out) is the inconsistency of the author lists in the bibliography, in which you have fMRI prep list most of its authors and the paper after using "& others". But that's more OCP spasms than anything else, probably.

Thanks for catching that, @smoia ! Some how that reference only imported the first handful of authors. I've made a suggestion to add the rest.

Thanks @emdupre!

Co-authored-by: Elizabeth DuPre <[email protected]>
KirstieJane
KirstieJane previously approved these changes Mar 9, 2021
Copy link
Member

@KirstieJane KirstieJane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

READ IT! Finally.

Held back a temptation to put 🎉 emojis after all the tedanas 😉

A few updates to my affiliation and added my funding - I hope that's ok?

All approved from my side. Many many apologies and great sadness for not being able to contribute more over the last year.

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Show resolved Hide resolved
Thanks @KirstieJane!

Co-authored-by: Kirstie Whitaker <[email protected]>
@tsalo
Copy link
Member Author

tsalo commented Mar 9, 2021

Thank you so much @KirstieJane!

@tsalo tsalo marked this pull request as ready for review March 9, 2021 15:25
@tsalo
Copy link
Member Author

tsalo commented Mar 9, 2021

I believe we have approval from all authors now, so @emdupre and I are planning to submit later today. @ME-ICA/tedana-devs if anyone has any final thoughts, please comment soon!

We're currently planning to merge the PR at 1pm EST, and then submit to JOSS at 2pm.

@tsalo tsalo changed the base branch from main to joss March 9, 2021 15:41
paper/paper.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsalo would it be a problem to update the reference to my paper to the "in press" Neuroimage version, rather than the bioRxiv one? I made the changes already, I hope it's ok.

paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
Co-authored-by: Stefano Moia <[email protected]>
paper/paper.bib Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@tsalo tsalo merged commit e07e90b into ME-ICA:joss Mar 9, 2021
@tsalo tsalo deleted the joss branch March 9, 2021 18:01
@tsalo tsalo mentioned this pull request Mar 9, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS manuscript
8 participants