-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS manuscript #693
JOSS manuscript #693
Conversation
Still need to check references.
I don't want to run the CI, but including |
I think you want space instead of |
Codecov Report
@@ Coverage Diff @@
## joss #693 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 26 26
Lines 2029 2029
=======================================
Hits 1900 1900
Misses 129 129 Continue to review full report at Codecov.
|
That seems to have worked. Thanks @jbteves! |
Co-authored-by: Elizabeth DuPre <[email protected]>
Co-authored-by: Dan Handwerker <[email protected]>
Ah no sorry, this is just the JOSS preview template ! It's also not filling in the year, for example :) You can confirm this by building a preview for PyBIDS, which includes a previously accepted paper. It will be updated when built by Whedon in the proper submission pipeline. |
The sub/sup scripts don't look like they're being rendered in the pdf. Maybe because the current syntax is html-specific? If JOSS uses pandoc, then the following change might work - T<sub>2</sub><sup>\*</sup>
+ T~2~^\*^ Edit: Or switch to math mode? But that often changes the font and I find that distracting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my reading, the JOSS submission guidelines ask for non-abbreviated references:
Also note that the references include full names of venues, e.g., journals and conferences, not abbreviations only understood in the context of a specific discipline.
I've made suggestions to that effect ! I've also gone through and changed the UNPUBLISHED
biblatex classes to MISC
so that we can add and display a DOI, which will almost definitely be requested by Whedon on submission !
Co-authored-by: Elizabeth DuPre <[email protected]> Co-authored-by: Joshua Teves <[email protected]>
Co-authored-by: Elizabeth DuPre <[email protected]>
@notZaki Your recommendation worked! Thanks! |
@smoia @CesarCaballeroGaudes you noted issues with some of the references, but PaperPile autogenerated them. We can change them now though! Would you mind adding comments about any incorrect references? |
Where is the link to the paper? I mean the final version with the references? |
You can use: http://whedon.theoj.org But it's building automatically from the files in this PR ! |
Ok, I've checked the current version. I assume @tsalo is referring to my comment about the fact that @smoia paper (Moia, Termenon) has been accepted in Neuroimage, but we don't have DOI number yet (at least at this time of the day). But the biorxiv website will indicate that the paper is accepted. Somehow similar with @jsheunis paper which is under review too. |
One suggestion/question: Why are the DOI numbers only included in the biorxiv papers, and not in the others? |
The preview looks good to me! The only thing I find strange (besides the inconsistency of DOIs that César was pointing out) is the inconsistency of the author lists in the bibliography, in which you have fMRI prep list most of its authors and the paper after using "& others". But that's more OCP spasms than anything else, probably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding DOIs to all article types
I had previously only added them under the preprints since I know that they'll be required for cross-checking any unpublished references, but I've made suggestions now to add them for all article classes ! |
Thanks for catching that, @smoia ! Some how that reference only imported the first handful of authors. I've made a suggestion to add the rest. |
Thanks @emdupre! Co-authored-by: Elizabeth DuPre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
READ IT! Finally.
Held back a temptation to put 🎉 emojis after all the tedanas 😉
A few updates to my affiliation and added my funding - I hope that's ok?
All approved from my side. Many many apologies and great sadness for not being able to contribute more over the last year.
Thanks @KirstieJane! Co-authored-by: Kirstie Whitaker <[email protected]>
Thank you so much @KirstieJane! |
I believe we have approval from all authors now, so @emdupre and I are planning to submit later today. @ME-ICA/tedana-devs if anyone has any final thoughts, please comment soon! We're currently planning to merge the PR at 1pm EST, and then submit to JOSS at 2pm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsalo would it be a problem to update the reference to my paper to the "in press" Neuroimage version, rather than the bioRxiv one? I made the changes already, I hope it's ok.
Co-authored-by: Stefano Moia <[email protected]>
Closes #669.
To do:
https://github.com/tsalo/tedana
for the repo andjoss
for the branch.Changes proposed in this pull request: