Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Add new contributors to Zenodo file #671

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 3, 2021

Closes None, but stems from #669.

Changes proposed in this pull request:

  • Add new contributors to the Zenodo file.

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling this @tsalo !
Similar to the #671 I think you'll have to push an empty commit to trigger tests once the DockerHub issue is resolved.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #671 (5ed1900) into main (197513d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          26       26           
  Lines        2030     2030           
=======================================
  Hits         1901     1901           
  Misses        129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197513d...5ed1900. Read the comment docs.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tsalo tsalo merged commit 9516608 into ME-ICA:main Feb 3, 2021
@tsalo tsalo deleted the add-contributors branch February 3, 2021 18:32
@jbteves
Copy link
Collaborator

jbteves commented Feb 3, 2021

@tsalo I'm actually a little confused; did you restart the checks on CircleCI or did they somehow auto-restart?

@tsalo
Copy link
Member Author

tsalo commented Feb 3, 2021

I restarted them. I have the necessary permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants