-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implement variance explained threshold-based PCA option #658
Conversation
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
- Coverage 93.59% 93.48% -0.12%
==========================================
Files 26 26
Lines 1984 2011 +27
==========================================
+ Hits 1857 1880 +23
- Misses 127 131 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @tsalo
I'd like to hear your thoughts on my comments @tsalo before approving, but aside from those nitpicks this looks great, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If we end up having a demand for adding a threshold option to other PCA algorithms, we may need to create dependent CLI parameter groups. But I see no reason to cross that bridge until we get there. Thanks again @tsalo !
Closes #492.
Changes proposed in this pull request: