Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implement variance explained threshold-based PCA option #658

Merged
merged 6 commits into from
Jan 22, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 21, 2021

Closes #492.

Changes proposed in this pull request:

  • Add an option to support a cumulative variance explained threshold-based PCA option.
  • Update tests.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #658 (e76c45e) into master (dae9f20) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   93.59%   93.48%   -0.12%     
==========================================
  Files          26       26              
  Lines        1984     2011      +27     
==========================================
+ Hits         1857     1880      +23     
- Misses        127      131       +4     
Impacted Files Coverage Δ
tedana/decomposition/pca.py 86.36% <100.00%> (+1.74%) ⬆️
tedana/workflows/parser_utils.py 96.29% <100.00%> (+5.38%) ⬆️
tedana/workflows/tedana.py 90.44% <100.00%> (+0.03%) ⬆️
tedana/decomposition/ica.py 82.75% <0.00%> (-13.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae9f20...e76c45e. Read the comment docs.

@tsalo tsalo requested review from eurunuela and jbteves January 21, 2021 23:53
eurunuela
eurunuela previously approved these changes Jan 22, 2021
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @tsalo

@jbteves
Copy link
Collaborator

jbteves commented Jan 22, 2021

I'd like to hear your thoughts on my comments @tsalo before approving, but aside from those nitpicks this looks great, thanks!

tedana/workflows/tedana.py Show resolved Hide resolved
tedana/workflows/parser_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If we end up having a demand for adding a threshold option to other PCA algorithms, we may need to create dependent CLI parameter groups. But I see no reason to cross that bridge until we get there. Thanks again @tsalo !

@tsalo tsalo merged commit 82bda7c into ME-ICA:master Jan 22, 2021
@tsalo tsalo deleted the thresh-pca branch January 22, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add threshold-based PCA option
3 participants