-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Adds a scree plot showing metric values and variance sorted by Kappa. #432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 84.57% 84.64% +0.07%
==========================================
Files 41 41
Lines 2910 2925 +15
==========================================
+ Hits 2461 2476 +15
Misses 449 449
Continue to review full report at Codecov.
|
@dowdlelt , @javiergcas is working on a little report that includes very similar scatterplots -- can you add a screenshot here, Javier ? 😸 |
I saw some chatter on mattermost about that - excited to see it! Would be far more useful as an interactive figure, after all.... |
its beautiful 😍, the images of my dreams! they even have color coding! |
I believe this PR does not make sense anymore, now that we are working on the dynamic reports. Should we close this PR? |
Are scree plots included in the current version of the dynamic reports? I agree that this PR should be closed, but we should make sure that the figures still end up being created. |
I believe they are - and while I'm excited to have dynamic reports - I also thought the intention was to have these as fallback/optional figures. For that reason I think it would be good for them to be at parity with the dynamic reports. |
I have my notes, so maybe I can actually pull this off. I'll give it a shot |
Awesome, thanks! If you have trouble just remember to reply here instead of Gitter since we're trying to push everything onto issues and PRs where possible. |
I've adapted to the minimization of the 'kitchen conversation' scheme better than I had hoped. And with any luck, I've also resolved the merge conflict - fingers crossed for testing. |
I think you did it correctly : - ) |
@dowdlelt since figures are now written by default you actually need to add the scree for all three integration tests, not just three-echo. Sorry, should have caught that when I looked over the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks @dowdlelt !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks folks, glad to close this out. |
Closes # None.
Purpose of this pull request is to generate a figure that shows the kappa and rho metric values (organized by kappa) as well as the variance explained by each component. This isn't a major figure, but it was included in some original evaluations. It also may highlight interesting things about variance and kappa values.
As an example, consider that component # 9 or so has very high variance (its pretty much a linear drift term) - but note that it also has kappa > rho.
Changes proposed in this pull request: