Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update numpy and Python requirements #397

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

effigies
Copy link
Contributor

Changes proposed in this pull request:

Closes #395.
Closes #396.

jbteves
jbteves previously approved these changes Sep 19, 2019
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @effigies ! Usually we squash and merge these, you may merge it when you're ready.

@effigies
Copy link
Contributor Author

@jbteves Sorry, added a commit after your review.

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #397 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   81.26%   81.27%   +<.01%     
==========================================
  Files          41       41              
  Lines        2375     2376       +1     
==========================================
+ Hits         1930     1931       +1     
  Misses        445      445
Impacted Files Coverage Δ
tedana/info.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b9275...9843ce3. Read the comment docs.

@emdupre
Copy link
Member

emdupre commented Sep 19, 2019

Thanks, @effigies and @jbteves !

@emdupre emdupre merged commit 95e9825 into ME-ICA:master Sep 19, 2019
@effigies effigies deleted the maint/requirements branch September 19, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set python_requires package metadata Set numpy minimum version to 1.14
3 participants