Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on empty input file & pre-commit updated to black version 24.2.0 #1031

Merged
merged 16 commits into from
Feb 18, 2024

Conversation

handwerkerd
Copy link
Member

@handwerkerd handwerkerd commented Feb 16, 2024

Closes #974. Closes #1007.

Changes proposed in this pull request:

  • ica_reclassify Errors on Empty Input File fix
  • This is the change @martinezeguiluz made in Fix error on empty input file  #1007 to fix the above issue plus merging my suggested update to that PR.
  • I also merged in the last 3 months of updates to main and fixed resulting style issues.
  • In trying to get this to pass the style check, I realized that pre-commit was using an older version of Black than CircleCI so I've updated the black version to use in .pre-commit-config.yaml

@tsalo
Copy link
Member

tsalo commented Feb 16, 2024

There's a linting issue, but other than that (maybe you need to update black?) it looks good to me.

@handwerkerd
Copy link
Member Author

I think I fixed the style issue. The precommit was the issue. I upgraded to black=24.2.0 and I think that's what CircleCI is using, but the precommit was using 23.10.0 and would un-edit the style change when I tried to push the commit. I needed to update the version of black in .pre-commit-config.yaml and now it looks like the style test is passing. I'll make a note of this in the PR title

@handwerkerd handwerkerd changed the title Fix error on empty input file (updated) Fix error on empty input file & pre-commit updated to black version 24.2.0 Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (6b82622) to head (e98e396).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
+ Coverage   89.51%   89.54%   +0.02%     
==========================================
  Files          26       26              
  Lines        3453     3462       +9     
  Branches      630      632       +2     
==========================================
+ Hits         3091     3100       +9     
  Misses        210      210              
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Dan.

@handwerkerd handwerkerd merged commit 670796b into ME-ICA:main Feb 18, 2024
16 checks passed
@handwerkerd
Copy link
Member Author

@all-contributors please add @martinezeguiluz for code

Copy link
Contributor

@handwerkerd

I've put up a pull request to add @martinezeguiluz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ica_reclassify Errors on Empty Input File
4 participants