-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error on empty input file & pre-commit updated to black version 24.2.0 #1031
Conversation
There's a linting issue, but other than that (maybe you need to update black?) it looks good to me. |
I think I fixed the style issue. The precommit was the issue. I upgraded to black=24.2.0 and I think that's what CircleCI is using, but the precommit was using 23.10.0 and would un-edit the style change when I tried to push the commit. I needed to update the version of black in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 89.51% 89.54% +0.02%
==========================================
Files 26 26
Lines 3453 3462 +9
Branches 630 632 +2
==========================================
+ Hits 3091 3100 +9
Misses 210 210
Partials 152 152 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you Dan.
@all-contributors please add @martinezeguiluz for code |
I've put up a pull request to add @martinezeguiluz! 🎉 |
Closes #974. Closes #1007.
Changes proposed in this pull request:
.pre-commit-config.yaml