Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binder examples #149

Closed
2 of 5 tasks
KirstieJane opened this issue Oct 31, 2018 · 11 comments
Closed
2 of 5 tasks

Add binder examples #149

KirstieJane opened this issue Oct 31, 2018 · 11 comments
Labels
documentation issues related to improving documentation for the project help wanted issues where we're particularly excited for contributions
Milestone

Comments

@KirstieJane
Copy link
Member

KirstieJane commented Oct 31, 2018

In #133 @tsalo added some really lovely jupyter notebooks to explain some aspects of the tedana🎉 processing.

It would be really cool if these were accessible through mybinder.

I don't have time to work on this so any help would be greatly appreciated! ✨ 😻 👾

I think this requires:

  • an update to the info.py file to include (for example) matplotlib, seaborn and nilearn.
    • Side note, thank you to Minn in the binder team for helping understand where binder goes looking for its requirements 😸
    • @emdupre would prefer this to be in the "DOCS REQUIRES" section so these packages aren't added when a regular user installs tedana.
    • An alternate idea is to make a binder/requirements.txt file that contains everything needed for the notebook. Note that this option won't run setup.py so everything needs to be added into that file, not just additional packages on top of those defined for tedana.
  • moving the jupyter notebooks to somewhere more accessible, eg an examples folder
  • uploading some data to OpenNeuro so it's easy to access
  • creating the binder link
  • updating the documentation to make it clear that this information exists!!
@KirstieJane KirstieJane added help wanted issues where we're particularly excited for contributions documentation issues related to improving documentation for the project labels Oct 31, 2018
@KirstieJane KirstieJane added this to the documentation milestone Oct 31, 2018
@souravsingh
Copy link

@tsalo @KirstieJane I would like to take a stab at the issue. Where do I start?

@tsalo
Copy link
Member

tsalo commented Jan 29, 2019

@souravsingh I don't know anything about binder, unfortunately, but the notebooks we want to binderize are in this folder. The five-echo data used for the notebooks is at https://osf.io/ea5v3, although the paths in the notebooks will have to be changed to fit whatever filesystem binder allows us to access.

@emdupre
Copy link
Member

emdupre commented Jan 30, 2019

Hi @souravsingh ! If you're not yet familiar with Binder, they have some really great resources to get started ! These tutorials might be the best first place to look.

As @tsalo said, the notebooks and data are already hosted online, so the issue would be pulling them together in the right environment. Which Binder is perfect for ! Let us know if you have any specific questions about next steps :)

Edited to add: @KirstieJane has done a great job of laying out the overall picture, so let us know which of those steps you have questions on !

@jbteves
Copy link
Collaborator

jbteves commented May 23, 2019

I see that the original PRs were closed for this. @KirstieJane do you mind if I edit your comment so that your task list is at the bottom and we can track progress?

@jbteves
Copy link
Collaborator

jbteves commented Jun 4, 2019

Note: we already have data hosted on OSF for our CI. Relevant links:

@KirstieJane
Copy link
Member Author

Totally fine to edit!! Go for it 🚀🌟

@jbteves
Copy link
Collaborator

jbteves commented Jun 4, 2019

Thanks! Done, now we can track progress directly on the issue title/tracker

@jbteves
Copy link
Collaborator

jbteves commented Jun 5, 2019

@KirstieJane @emdupre @tsalo I have an example of it working for optimal combination here. It's in binder/optimal_combination_workflow_plots.ipynb. I haven't adjusted the workflow one yet but I'll replace the hardcoded paths similarly. The big thing is whether we want to use kundu, kundu-stabilize or revise it to be mle.

@stale
Copy link

stale bot commented Nov 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to tedana:tada: !

@stale stale bot added the stale label Nov 9, 2019
@emdupre
Copy link
Member

emdupre commented Nov 10, 2019

I'd like to suggest we use Jupytext for this, so that we're including .py rather than .ipynb files in our repository. It will keep the version history much more manageable !

And if we add Jupytext to the dev-requirements and put the correct YAML front matter in the examples, Binder will open the python scripts as Jupyter Notebooks ! ✨

@stale stale bot removed the stale label Nov 10, 2019
@stale
Copy link

stale bot commented Feb 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to tedana:tada: !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to improving documentation for the project help wanted issues where we're particularly excited for contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants