Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v1.0.0 #14

Merged
merged 5 commits into from
Oct 18, 2023
Merged

release v1.0.0 #14

merged 5 commits into from
Oct 18, 2023

Conversation

ianmkenney
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #14 (f1b9b6e) into main (5eda30e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@ianmkenney ianmkenney requested a review from orbeckst October 17, 2023 01:01
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please flesh out the CHANGELOG: it should be clearer where the original code came from and when things happened (see MDAnalysis/mdaencore#41).

@ianmkenney ianmkenney requested a review from orbeckst October 17, 2023 19:56
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Oliver Beckstein <[email protected]>
@ianmkenney ianmkenney merged commit bbfd392 into main Oct 18, 2023
23 checks passed
@ianmkenney ianmkenney deleted the release_v1.0.0 branch October 18, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants