Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI for py3.12 issue #39

Merged
merged 4 commits into from
Nov 5, 2023
Merged

fix CI for py3.12 issue #39

merged 4 commits into from
Nov 5, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 31, 2023

Please see MDAnalysis/cookiecutter-mdakit#93 for more details.

Also:

  • Bump up versioneer to 0.29 to eventually enable py3.12

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #39 (a5eeef5) into main (7211e63) will decrease coverage by 1.43%.
The diff coverage is 100.00%.

Additional details and impacted files

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmacdope
Copy link
Member

Oh wait RTD, illl fix that.

@pep8speaks
Copy link

pep8speaks commented Nov 2, 2023

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 16:1: E402 module level import not at top of file

Line 226:23: E203 whitespace before ':'
Line 291:81: E501 line too long (87 > 80 characters)
Line 326:81: E501 line too long (83 > 80 characters)
Line 375:81: E501 line too long (88 > 80 characters)
Line 404:81: E501 line too long (84 > 80 characters)
Line 495:81: E501 line too long (84 > 80 characters)
Line 678:81: E501 line too long (82 > 80 characters)

Comment last updated at 2023-11-05 08:51:07 UTC

@IAlibay
Copy link
Member Author

IAlibay commented Nov 2, 2023

@hmacdope I've added the necessary fix here

@hmacdope hmacdope merged commit 405cf6d into main Nov 5, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Nov 5, 2023

I've applied black locally and the linter here still complains 🤷🏽 I'm calling it a day on this one.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 5, 2023

@hmacdope I'm leaving it up to you to merge.

@hmacdope
Copy link
Member

hmacdope commented Nov 5, 2023

Thanks @IAlibay :)

@xhgchen
Copy link
Member

xhgchen commented Nov 5, 2023

Thanks @IAlibay! Might be failing because I set up black to check for --line-length 79. Will try removing that and seeing if it is less strict.

Edit: so removing the --line-length 79 requirement would cause everything else to fail the check, so I think I'll just reformat the _version.py file instead of reformatting everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants