Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining analysis.nuclinfo regression tests #978

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

tylerjereddy
Copy link
Member

This PR adds the remaining regression tests needed to fully cover analysis.nuclinfo, and should close Issue #790 if it looks ok.

@tylerjereddy
Copy link
Member Author

Looks like there are (stochastic?) errors in parts of the testing infrastructure I didn't touch. I haven't been reading all the discussions lately so I'll let another core dev take a look before restarting them.

@coveralls
Copy link

coveralls commented Sep 11, 2016

Coverage Status

Coverage increased (+0.6%) to 84.937% when pulling 807b9fb on issue_790_nuclinfo_coverage into 080f861 on develop.

@orbeckst
Copy link
Member

orbeckst commented Sep 11, 2016

I don't really have a clue why one test errors with "That's a bad zip file" https://travis-ci.org/MDAnalysis/mdanalysis/jobs/159122862 but I am just restarting (the "full test" suite passed).

@richardjgowers
Copy link
Member

@orbeckst coveralls API is appearing here, success!

@richardjgowers richardjgowers merged commit 89e6633 into develop Sep 12, 2016
@kain88-de kain88-de deleted the issue_790_nuclinfo_coverage branch November 27, 2016 10:48
abiedermann pushed a commit to abiedermann/mdanalysis that referenced this pull request Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants