Regression tests for nuclinfo.minor_pair #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_minor_pair_1(self): | ||
| val = nuclinfo.minor_pair(self.u, 3, 17, seg1='RNAA', seg2='RNAA') | ||
| assert_almost_equal(val, 16.649, decimal=3) |
There was a problem hiding this comment.
where do these values come from? Might be useful when the test fails after a refactor.
There was a problem hiding this comment.
If it's regression then probably just from running the tests in filling in the values that are needed to make the tests pass.
There was a problem hiding this comment.
Yes, that is what I did.
Anyone who sacrifices a few spare minutes for writing tests is a hero! |
|
Looking good! Can definitely chip away at coverage like this |
abiedermann
pushed a commit
to abiedermann/mdanalysis
that referenced
this pull request
Jan 5, 2017
* Added two regression tests for MDAnalysis.analysis.nuclinfo.minor_pair * Added CHANGELOG entry for new MDAnalysis.analysis.nuclinfo.minor_pair regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds two regression tests for
MDAnalysis.analysis.nuclinfo.minor_pairIt is a subset of the additions required for Issue #790. I realize that optimally I might do all of the regression tests and close the issue, but just wanted something relatively simple I could "get done" with a few spare minutes.