Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed nframes to n_frames #891

Merged
merged 1 commit into from
Jul 6, 2016
Merged

Conversation

jdetle
Copy link
Contributor

@jdetle jdetle commented Jul 6, 2016

Fixes #890

Changes made in this Pull Request:

  • Changed nframes to n_frames for style consistency in analysis modules

PR Checklist

  • Tests?
  • CHANGELOG updated?
  • Issue raised/referenced?

Updated CHANGELOG

Removed references to nframes in tests
@@ -13,7 +13,7 @@ The rules for this file:
* release numbers follow "Semantic Versioning" http://semver.org

------------------------------------------------------------------------------
??/??/16 kain88-de, jdetle, fiona-naughton, richardjgowers, tyler.je.reddy
??/??/16 kain88-de, fiona-naughton, richardjgowers, tyler.je.reddy, jdetle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you touch this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that names are appended in the order of most recent changes. I realize now that probably doesnt matter haha

@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage remained the same at 80.38% when pulling 80eb6d3 on jdetle:nframes into 7220db5 on MDAnalysis:develop.

@kain88-de kain88-de merged commit 852daec into MDAnalysis:develop Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants