Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some use of deprecated methods #825

Merged
merged 2 commits into from
Apr 19, 2016
Merged

Removed some use of deprecated methods #825

merged 2 commits into from
Apr 19, 2016

Conversation

richardjgowers
Copy link
Member

Should remove a lot of dep warnings that come up from within the code WRT positions/velocities/forces

@dotsdl dotsdl self-assigned this Apr 13, 2016
coordinates = deprecate(coordinates,
message="{}; use `positions` property instead".format(_SIXTEEN_DEPRECATION))
.. deprecated:: 0.7.6
In new scripts use :meth:`AtomGroup.get_positions` preferrably.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change this note, or add a new deprecation note.

@kain88-de
Copy link
Member

@richardjgowers looks like you honestly broke the tests.

@richardjgowers
Copy link
Member Author

Oops! I've been conferencing but I'll get on it, the warnings are annoying.

On Sat, 16 Apr 2016 19:41 kain88-de, [email protected] wrote:

@richardjgowers https://github.com/richardjgowers looks like you
honestly broke the tests.


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#825 (comment)

@kain88-de
Copy link
Member

@richardjgowers do you know how to filter the output of the test for deprecation messages?

@richardjgowers
Copy link
Member Author

@kain88-de not sure what you mean, I didn't really have a sophisticated approach here. Might be fixed now

@kain88-de kain88-de mentioned this pull request Apr 18, 2016
@@ -69,13 +69,13 @@
The same is mostly true for :class:`Residue` instances although they are
derived from :class:`Atom` instances: all :class:`Atom` objects with the same
:attr:`Atom.resid` are bundled into a single :class:`Residue` with
:class:`Residue.id` = *resid*. This means that just changing, say, the residue
:class:`Residue.resid` = *resid*. This means that just changing, say, the residue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these. I completely forgot to check all the docs for old usage patterns.

@dotsdl
Copy link
Member

dotsdl commented Apr 18, 2016

Looks good to me. @kain88-de want to give it a glance before we merge, since I'm a bit too close for completely clear eyes?

@kain88-de kain88-de merged commit 9e049f6 into develop Apr 19, 2016
@richardjgowers richardjgowers deleted the depremovals branch April 19, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants