-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed some use of deprecated methods #825
Conversation
coordinates = deprecate(coordinates, | ||
message="{}; use `positions` property instead".format(_SIXTEEN_DEPRECATION)) | ||
.. deprecated:: 0.7.6 | ||
In new scripts use :meth:`AtomGroup.get_positions` preferrably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change this note, or add a new deprecation note.
@richardjgowers looks like you honestly broke the tests. |
Oops! I've been conferencing but I'll get on it, the warnings are annoying. On Sat, 16 Apr 2016 19:41 kain88-de, [email protected] wrote:
|
@richardjgowers do you know how to filter the output of the test for deprecation messages? |
@kain88-de not sure what you mean, I didn't really have a sophisticated approach here. Might be fixed now |
@@ -69,13 +69,13 @@ | |||
The same is mostly true for :class:`Residue` instances although they are | |||
derived from :class:`Atom` instances: all :class:`Atom` objects with the same | |||
:attr:`Atom.resid` are bundled into a single :class:`Residue` with | |||
:class:`Residue.id` = *resid*. This means that just changing, say, the residue | |||
:class:`Residue.resid` = *resid*. This means that just changing, say, the residue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing these. I completely forgot to check all the docs for old usage patterns.
Looks good to me. @kain88-de want to give it a glance before we merge, since I'm a bit too close for completely clear eyes? |
Should remove a lot of dep warnings that come up from within the code WRT positions/velocities/forces