Dynamic author list works on python 3 #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic author list introduced in MDAnalysis#787 did not work on python 3 because of the way encoding was handled. This commit fixes the handling of file encodings by using the codecs library.
| @@ -364,7 +365,7 @@ def dynamic_author_list(): | |||
| "Chronological list of authors" title. | |||
| """ | |||
| authors = [] | |||
| with open('AUTHORS') as infile: | |||
| with codecs.open('AUTHORS', encoding='utf-8') as infile: | |||
There was a problem hiding this comment.
This might fail in that case that we can't write to our dir. Better check now. I vote for wrapping the dynamic_author_list call below in a try/except.
If the user cannot write in the MDAnalysis source directory, writing the list of authors will fail. This commit wrap the generation so the install proceed with a warning instead of crashing.
mnmelo
added a commit
that referenced
this pull request
Mar 21, 2016
Dynamic author list works on python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported by @orbeckst in a comment bellow #787.
The dynamic author list introduced in #787 did not work on python 3
because of the way encoding was handled. This commit fixes the handling
of file encodings by using the codecs library.