-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'MDAnalysis.analysis.align' parallelization #4738
Draft
talagayev
wants to merge
18
commits into
MDAnalysis:develop
Choose a base branch
from
talagayev:align_parllel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added backends and aggregators for AverageStructure
added AverageStructure to conftest
added client_AverageStructure
added for AlignTraj backends and aggregator
added client_AlignTraj
added client_AlignTraj to tests
Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-10-18 21:03:42 UTC |
PEP fixes
fixing PEP
fixing pep
fixing pep
fixing pep
fixing pep
fixing pep
adjusted position of inputs
fix positional arguments
added multiprocessing to test
removed multiprocessing from AlignTraj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4659 attempt
Changes made in this Pull Request:
backends
andaggregators
toAlignTraj
andAverageStructure
inanalysis.align
.client_AlignTraj
andclient_AverageStructure
inconftest.py
client_AlignTraj
andclient_AverageStructure
inrun()
intest_align.py
Currently for
AlignTraj
it only acceptsserial
anddask
withmultiprocessing
leading to the pytests taking forever. An additional error that appears is the following:OSError: File opened in mode: self.mode. Reading only allow in mode "r"
For
AverageStructure
the Failure that appears is the following:AttributeError: 'numpy.ndarray' object has no attribute 'load_new'
Which leads me to believe that
AverageStructure
can not be parallelized, but I would need additional opinions on it and onAlignTraj
:)PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4738.org.readthedocs.build/en/4738/