-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two doctest fixes #4366
Two doctest fixes #4366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS
as part of this PR.
Linter Bot Results:Hi @ljwoods2! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4366 +/- ##
==========================================
Coverage 93.41% 93.41%
==========================================
Files 171 185 +14
Lines 22512 23625 +1113
Branches 4129 4129
==========================================
+ Hits 21029 22069 +1040
- Misses 963 1036 +73
Partials 520 520 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ljwoods2, LGTM. Please update the CHANGELOG
, then I think it's good to go.
Thanks @ljwoods2. Can you please also add a line explaining the fix to the CHANGELOG, under the "Fixes" entry? |
Thanks @ljwoods2. Please solve the conflicts, the |
@RMeli Got it, thank you for being patient and explaining the process! |
Fixes #3925
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4366.org.readthedocs.build/en/4366/