-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate lib.util.which #4340
Deprecate lib.util.which #4340
Conversation
Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-11-05 12:37:53 UTC |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4340 +/- ##
===========================================
- Coverage 93.37% 93.36% -0.02%
===========================================
Files 170 184 +14
Lines 22299 23410 +1111
Branches 4075 4075
===========================================
+ Hits 20822 21856 +1034
- Misses 962 1036 +74
- Partials 515 518 +3
☔ View full report in Codecov by Sentry. |
@@ -228,7 +229,7 @@ def hole(pdbfile, | |||
warnings.warn(msg.format(output_level)) | |||
|
|||
# get executable | |||
exe = util.which(executable) | |||
exe = shutil.which(executable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not looking to add tests to cover these if the migration is also being done in hole2-mdakit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @IAlibay
Fixes #3649
Notes:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4340.org.readthedocs.build/en/4340/