-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TRZ #4335
Deprecate TRZ #4335
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM
Typical github won't let me unlink the issue - todo: remember to re-open the TRZ issue so we don't close it until it's actually removed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4335 +/- ##
==========================================
Coverage 93.37% 93.37%
==========================================
Files 170 184 +14
Lines 22295 23406 +1111
Branches 4075 4075
==========================================
+ Hits 20818 21856 +1038
- Misses 962 1035 +73
Partials 515 515
☔ View full report in Codecov by Sentry. |
Test failure is expecting - merging. |
Towards #4311
Changes:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4335.org.readthedocs.build/en/4335/