Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TRZ #4335

Merged
merged 5 commits into from
Nov 5, 2023
Merged

Deprecate TRZ #4335

merged 5 commits into from
Nov 5, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 5, 2023

Towards #4311

Changes:

  • Deprecate the TRZ reader & writer

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4335.org.readthedocs.build/en/4335/

Copy link

github-actions bot commented Nov 5, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/6760455762/job/18374242487


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@IAlibay IAlibay changed the title [WIP] deprecate TRZ Deprecate TRZ Nov 5, 2023
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@IAlibay
Copy link
Member Author

IAlibay commented Nov 5, 2023

Typical github won't let me unlink the issue - todo: remember to re-open the TRZ issue so we don't close it until it's actually removed.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (540a980) 93.37% compared to head (e3d3673) 93.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4335     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22295    23406   +1111     
  Branches      4075     4075             
==========================================
+ Hits         20818    21856   +1038     
- Misses         962     1035     +73     
  Partials       515      515             
Files Coverage Δ
package/MDAnalysis/coordinates/TRZ.py 84.75% <100.00%> (+0.23%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 5, 2023

Test failure is expecting - merging.

@IAlibay IAlibay merged commit cb26ebc into develop Nov 5, 2023
20 of 22 checks passed
@IAlibay IAlibay deleted the drop-trz branch November 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants