Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.12 to minimal deps CI run #4319

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Add 3.12 to minimal deps CI run #4319

merged 5 commits into from
Oct 27, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 12, 2023

Changes made in this Pull Request:

  • Add py3.12 to minimal deps CI run
  • Add py3.12 to pypi checks
  • Fix pyproject.toml

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4319.org.readthedocs.build/en/4319/

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e9d19b) 93.37% compared to head (fddd897) 93.38%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4319      +/-   ##
===========================================
+ Coverage    93.37%   93.38%   +0.01%     
===========================================
  Files          170      184      +14     
  Lines        22295    23450    +1155     
  Branches      4075     4092      +17     
===========================================
+ Hits         20817    21898    +1081     
- Misses         962     1034      +72     
- Partials       516      518       +2     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 12, 2023

Blocked by biopython - I'm trying to get their feedstock fixed, it's taking a bit of time

@IAlibay IAlibay closed this Oct 19, 2023
@IAlibay IAlibay reopened this Oct 19, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Oct 21, 2023

Blocked by biopython - I'm trying to get their feedstock fixed, it's taking a bit of time

fixed

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @IAlibay

@IAlibay IAlibay merged commit 03a9550 into develop Oct 27, 2023
35 checks passed
@IAlibay IAlibay deleted the py312_ci branch October 27, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants