-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable old Boltzmann key with DeprecationWarning
#4230
Conversation
* Subclass dict and wrap `__getitem__` with `DeprecationWarning`
* Add test for old `Boltzman_constant` key * Add test for deprecation warning with old `Boltzman_constant` key
Linter Bot Results:Hi @xhgchen! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog entry please
Done! Was just in the middle of doing it as you replied 😅 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4230 +/- ##
========================================
Coverage 93.62% 93.62%
========================================
Files 193 193
Lines 25295 25304 +9
Branches 4063 4064 +1
========================================
+ Hits 23683 23692 +9
Misses 1096 1096
Partials 516 516
☔ View full report in Codecov by Sentry. |
Some issues are appearing with the CI and Codecov, but I don't think they're from my PR. |
Thanks for sorting this out @xhgchen :) |
Fixes #4229
Changes made in this Pull Request:
'Boltzman_constant'
key in subclassed dict and wrap__getitem__
withDeprecationWarning
'Boltzman_constant'
key'Boltzman_constant'
keyPR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4230.org.readthedocs.build/en/4230/