Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 32bit from azure CI #4176

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Drop 32bit from azure CI #4176

merged 3 commits into from
Jun 26, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jun 23, 2023

Fixes #3858

Am I correct in u ndrestanding this is a thing now?


📚 Documentation preview 📚: https://mdanalysis--4176.org.readthedocs.build/en/4176/

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4d6d668) 93.61% compared to head (5a4e29d) 93.61%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4176   +/-   ##
========================================
  Coverage    93.61%   93.61%           
========================================
  Files          193      193           
  Lines        25168    25168           
  Branches      4058     4058           
========================================
  Hits         23560    23560           
  Misses        1092     1092           
  Partials       516      516           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a note in CHANGELOG 🪓

@RMeli RMeli requested a review from orbeckst June 26, 2023 10:42
@RMeli RMeli merged commit c87a3cd into develop Jun 26, 2023
@RMeli RMeli deleted the remove_32bit branch August 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecating windows 32bit support
3 participants