-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAMMPS continuous check in chain trajectory #4170
LAMMPS continuous check in chain trajectory #4170
Conversation
Linter Bot Results:Hi @jaclark5! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4170 +/- ##
========================================
Coverage 93.61% 93.61%
========================================
Files 193 193
Lines 25169 25170 +1
Branches 4059 4059
========================================
+ Hits 23561 23562 +1
Misses 1092 1092
Partials 516 516
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaclark5 see my comments.
cd9ed8b
to
fbc491b
Compare
fbc491b
to
3714025
Compare
@jaclark5 if you can resolve conflicts I can re-review ASAP. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing then should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaclark5!
Fixes #3546
This is an alternative to PR #3849
Changes made in this Pull Request:
ts.data['time']
in LAMMPSDumpReaderPR Checklist
📚 Documentation preview 📚: https://mdanalysis--4170.org.readthedocs.build/en/4170/