-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified guess_atom_element for more accurate guess #4168
Merged
Merged
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
921616b
modified guess_atom_element for more accurate guess
pillose e358dcb
Merge branch 'MDAnalysis:develop' into develop
pillose da13425
add test for new behavior
80c8eb2
Merge branch 'develop' of github.com:pillose/mdanalysis into develop
1ce5387
updated AUTHORS and CHANGELOG
76d6bec
revised the order of CHANGELOG
aa7f457
add commnets and modified the code a little
878b496
Merge branch 'develop' of github.com:pillose/mdanalysis into develop
35abfaa
add my username
3454ceb
Update package/CHANGELOG
pillose 7b5285a
Update package/AUTHORS
pillose ed4bbb4
Update package/MDAnalysis/topology/guessers.py
pillose d1d4f54
Merge branch 'develop' of github.com:pillose/mdanalysis into develop
075f2dc
Merge branch 'develop' into develop
pillose f77c6f5
Update AUTHORS
pillose 5fe84ab
add guesser tests
pillose 9d30a1e
Update test_guessers.py
pillose 575e6eb
Update guessers.py
pillose 19511fc
Merge branch 'develop' into develop
pillose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,6 +104,9 @@ def test_guess_atom_element_1H(self): | |
('zn', 'ZN'), | ||
('Ca2+', 'CA'), | ||
('CA', 'C'), | ||
('N0A', 'N'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One more nit sorry could you test Na+ -> Na? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just added two tests for Na+ and Cu2+ |
||
('C0U', 'C'), | ||
('C0S', 'C') | ||
)) | ||
def test_guess_element_from_name(self, name, element): | ||
assert guessers.guess_atom_element(name) == element | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies if I'm missing something obvious, but do you need to apply filter again here? You've already removed the
''
entries and you shouldn't have anyNone
entries ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think I made a mistake while modifying the code...