-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP29, raise Python to 3.9 #4115
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4115 +/- ##
========================================
Coverage 93.59% 93.59%
========================================
Files 192 192
Lines 25134 25134
Branches 4056 4056
========================================
Hits 23524 23524
Misses 1092 1092
Partials 518 518 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @RMeli for doing the actual reviewing
Presumably, a bunch of secondary docs might need updating as well but I suppose we do this when it shows up. |
Azure 3.9 32bit is unhappy
|
yeah turns out that h5py hasn't released 32bit binaries for py3.9+ I'm just going to skip that pip install in that case. |
afaik nothing in this repo, mostly userguide... which needs a good update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, pyproject.toml
is always the trickiest to be sure about/parse, but seems sensible I think.
NumPy and SciPy have also dropped |
Towards 2.5.0 release
We won't release until the 14th (at least I'm not planning to do a release over Easter holidays), so I think we can safely say we'll bump things up to Python 3.9 in line with NEP29.
PR Checklist
📚 Documentation preview 📚: https://readthedocs-preview--4115.org.readthedocs.build/en/4115/