resolved Issue #4026 updated request of #4029 #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4049 +/- ##
========================================
Coverage 93.53% 93.53%
========================================
Files 191 191
Lines 25063 25063
Branches 4042 4042
========================================
Hits 23443 23443
Misses 1099 1099
Partials 521 521
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@fiona-naughton would you mind looking after this PR? |
Closed
|
@fiona-naughton I unassigned you because I was supposed to be in charge of the predecessor PR #4029. Sorry for the confusion. |
RMeli
reviewed
Mar 1, 2023
package/CHANGELOG
Outdated
| @@ -26,6 +26,7 @@ Fixes | |||
| * Fix MSD docs to use the correct error metric in example (Issue #3991) | |||
| * Add 'PairIJ Coeffs' to the list of sections in LAMMPSParser.py | |||
| (Issue #3336) | |||
| * Fix typo in hbond_analysis.py (Issue #4026) | |||
There was a problem hiding this comment.
Entries should be sorted newest-first
There was a problem hiding this comment.
yes... but this does not even need one
Thanks for checking @RMeli !
orbeckst
requested changes
Mar 1, 2023
Co-authored-by: Oliver Beckstein <[email protected]>
orbeckst
approved these changes
Mar 1, 2023
|
Cycling again for Codecov |
|
Thank you @MoSchaeffler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4026
Changes made in this Pull Request:
PR Checklist