-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: EDRReader fails when reading only one step #4030
Conversation
Codecov ReportBase: 93.53% // Head: 93.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #4030 +/- ##
========================================
Coverage 93.53% 93.53%
========================================
Files 191 191
Lines 25062 25063 +1
Branches 3547 3548 +1
========================================
+ Hits 23442 23443 +1
Misses 1099 1099
Partials 521 521
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Rocco Meli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If n_steps is defined a priori then you don't need to also define SINGLE_FRAME?
Co-authored-by: Irfan Alibay <[email protected]>
Good point, cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failure is fixed in develop, I'm happy with things as-is.
Fixes #3999
Changes made in this Pull Request:
the _read_next_step()
method now checks if only one frame is present. If so, theStopIteration
exception is not raised.PR Checklist