-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set expected list of elements for Parmed PSF test #4016
Conversation
Codecov ReportBase: 93.52% // Head: 93.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #4016 +/- ##
========================================
Coverage 93.52% 93.52%
========================================
Files 190 190
Lines 25028 25028
Branches 3542 3542
========================================
Hits 23407 23407
Misses 1100 1100
Partials 521 521 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@MDAnalysis/coredevs can I get a quick check here - this issue is making CI fail across the board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Is there anything in the docs that we need to add about new capabilities?
Do we need to restrict to newer versions of parmed or is the new capability just incidental and it doesn't really matter to us?
@orbeckst It's purely incidental & only affects tests - i.e. upstream now supports it so if you use the latest parmed you'll get elements instead of empty strings. Otherwise you'll get empty strings (i.e. the expected behaviour before the previous release). I've clarified this in the changelog. |
Fixes #4015 * fix expected list of elements for Parmed PSF test
Fixes #4015
Changes made in this Pull Request:
PR Checklist