Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering pytng reader warnings (resolves #3986) #4010

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

ooprathamm
Copy link
Contributor

@ooprathamm ooprathamm commented Jan 26, 2023

Fixes #3986

Changes made in this Pull Request:

  • added filter for repeated warning in test_tng.py

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 93.52% // Head: 93.52% // No change to project coverage 👍

Coverage data is based on head (940bef4) compared to base (096f799).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4010   +/-   ##
========================================
  Coverage    93.52%   93.52%           
========================================
  Files          190      190           
  Lines        25028    25028           
  Branches      3542     3542           
========================================
  Hits         23407    23407           
  Misses        1100     1100           
  Partials       521      521           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ooprathamm ooprathamm changed the title Filtering pytng reader warnings [solves:#3986] Filtering pytng reader warnings [solves: #3986] Jan 26, 2023
@ooprathamm ooprathamm changed the title Filtering pytng reader warnings [solves: #3986] Filtering pytng reader warnings ( solves: #3986 ) Jan 26, 2023
testsuite/setup.cfg Outdated Show resolved Hide resolved
@ooprathamm
Copy link
Contributor Author

ooprathamm commented Jan 26, 2023

@IAlibay I hope this is what you meant. The filter has been applied specifically for test_tng.py

Current captured warnings -
image

@ooprathamm ooprathamm requested a review from IAlibay January 26, 2023 16:00
@ooprathamm ooprathamm changed the title Filtering pytng reader warnings ( solves: #3986 ) Filtering pytng reader warnings (resolves #3986) Jan 28, 2023
@orbeckst
Copy link
Member

@ooprathamm could you please edit your original PR comment at the top to include the issue number that you're fixing as Fixes #3986 ? This links your PR to the issue and is an important part of organizing work on the project. Thanks.

@hmacdope
Copy link
Member

@ooprathamm just double checking do you have pytng installed? Otherwise the tests will be skipped.

@hmacdope
Copy link
Member

hmacdope commented Feb 1, 2023

I verified on my own setup that warnings down from ~900 to ~80 so seems to work

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion @IAlibay and myself have decided we want to eliminate all the warnings.
Try adding the same filter to more test fixture classes until the warning count gets to 0 for the "Stride of block" warnings.

@ooprathamm
Copy link
Contributor Author

I verified on my own setup that warnings down from ~900 to ~80 so seems to work

@hmacdope the difference in warnings seems to be from other optional dependencies in your system (for mine and as stated in #3986 ~600 to ~7 warnings)

is there list of optional dependencies that I need to install other than pytng

@hmacdope
Copy link
Member

hmacdope commented Feb 1, 2023

No just pytng should be fine! Try and get the last 7 gone and then we should be good to go.

@ooprathamm
Copy link
Contributor Author

image

@hmacdope filtered all the warnings in test_tng also removed deprecation warning thrown for xdrlib in topology package

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing, also please add yourself to AUTHORS and your name to the top of the changelog (a changelog entry is not required). We also would ask if you could introduce yourself on the mailing list if you haven't done so (please include your github handle).

package/MDAnalysis/topology/TPRParser.py Outdated Show resolved Hide resolved
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing from me.

package/MDAnalysis/topology/TPRParser.py Outdated Show resolved Hide resolved
@ooprathamm ooprathamm reopened this Feb 9, 2023
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think you have already introduced yourself on the Mailing list, so good to go from me.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@hmacdope hmacdope merged commit b928ff1 into MDAnalysis:develop Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytng reader tests generate a lot of warnings
4 participants