Increase minimum numpy version to 1.21 #3983
Conversation
Codecov ReportBase: 93.50% // Head: 93.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #3983 +/- ##
========================================
Coverage 93.50% 93.50%
========================================
Files 190 190
Lines 24943 24943
Branches 3523 3523
========================================
Hits 23322 23322
Misses 1100 1100
Partials 521 521
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
IAlibay
changed the title
IAlibay
changed the title
|
I think that might be fine now, I'm not a typing expert though so I'm heavily relying on mypy to tell me if I'm wrong (also I've only made changes where it was indicated in |
| reference_positions: np.ndarray = reference # type: ignore | ||
| configuration_positions: np.ndarray = configuration # type: ignore | ||
| reference_positions: npt.NDArray = reference # type: ignore | ||
| configuration_positions: npt.NDArray = configuration # type: ignore |
There was a problem hiding this comment.
Do we want to have subtyping on eg npt.NDArray[np.float32] ?
There was a problem hiding this comment.
Unsure, but I'd probably ask that this get punted to a separate issue (unless these changes lessen the quality of typing from what it used to be)?
I'd prefer not move the goalpost here from "bumping up our numpy requirements" to "incidentally dealing with a ton of typing issues"
There was a problem hiding this comment.
Yep totally fair. I'll raise an issue once merged. The typing here is improvement for sure, it can just be more stringent but agree its a separate issue.
|
Note fixes #3748 |
As per NEP29, the 2.5.0 release of MDA will happen ~ March 2023 and will be Python 3.8+ & NumPy 1.21+
See: https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table
Changes made in this Pull Request:
PR Checklist