Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to unpin coverage #3877

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Attempting to unpin coverage #3877

merged 2 commits into from
Dec 2, 2022

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 25, 2022

Unpins coverage and pytest-cov from tests.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 94.35% // Head: 94.34% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bfa1eba) compared to base (b891157).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3877      +/-   ##
===========================================
- Coverage    94.35%   94.34%   -0.01%     
===========================================
  Files          194      194              
  Lines        25031    25031              
  Branches      3374     3461      +87     
===========================================
- Hits         23617    23616       -1     
- Misses        1365     1366       +1     
  Partials        49       49              
Impacted Files Coverage Δ
package/MDAnalysis/analysis/encore/utils.py 88.32% <0.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 26, 2022

To avoid what happened last time (where it was fine and then broke everything a few days later), we should re-run CI several times before we merge this.

@IAlibay IAlibay marked this pull request as ready for review November 29, 2022 01:33
@IAlibay
Copy link
Member Author

IAlibay commented Nov 29, 2022

CI ran 6 times here and it hasn't failed, so I'm going to go ahead and say it's probably stable enough to try this in production.

@IAlibay IAlibay changed the title [wip] Attempting to unpin coverage Attempting to unpin coverage Nov 30, 2022
Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IAlibay IAlibay merged commit dd92db8 into develop Dec 2, 2022
@IAlibay IAlibay deleted the coverage-unpin branch December 2, 2022 14:15
jaclark5 pushed a commit to jaclark5/mdanalysis that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants