Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove universal wheel creation from setup.cfg files #3763

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 23, 2022

Easy enough one whilst I'm making Saturday night dinner

We need to drop the creation of universal wheels because a) we have C extension, b) we don't support py2 anymore.

see: https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels

Note: as far as I'm aware there's no [wheel] entry anyways, it should be [bdist_wheel], but it does get interpreted by setuptools as the same. Removing the entry changes the generated wheel from MDAnalysisTests-2.3.0.dev0-py2.py3-none-any.whl to MDAnalysisTests-2.3.0.dev0-py3-none-any.whl which is what we're looking for

In practice we don't create them anyways, but we can see from conda-forge that there is an attempt at creating them as part of the package build.

Changes made in this Pull Request:

  • Remove

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #3763 (96d539e) into develop (d5c7cb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3763   +/-   ##
========================================
  Coverage    94.31%   94.31%           
========================================
  Files          192      192           
  Lines        24752    24752           
  Branches      3338     3338           
========================================
  Hits         23345    23345           
  Misses        1359     1359           
  Partials        48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c7cb9...96d539e. Read the comment docs.

@IAlibay IAlibay merged commit 886cb60 into develop Jul 24, 2022
@IAlibay IAlibay deleted the no-universal branch July 24, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants