-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated template asv.conf.json to Python 3.8 #3521
Conversation
- fix #3430 - automated benchmarks were updated (see MDAnalysis/benchmarks#11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI :)
Thanks for the quick review. Could you merge it when ready, please?
Thanks!
|
Cancelling CI and restarting - something off with the docs build, seeing if it's intermittent. |
Codecov Report
@@ Coverage Diff @@
## develop #3521 +/- ##
========================================
Coverage 94.06% 94.06%
========================================
Files 176 176
Lines 23288 23288
Branches 3305 3305
========================================
Hits 21905 21905
Misses 1337 1337
Partials 46 46 Continue to review full report at Codecov.
|
oof something is going wrong with CI... looks like runners are having a field day but gh status is being fine. Hold for re-run in a few hours? |
re-triggered |
Still failing on docs - let me check if there's been a recent update to sphinx related things. |
This seems to be the major difference between the last passing CI run and the current failure: "intersphinx inventory 'https://docs.scipy.org/doc/numpy/objects.inv' not readable due to ValueError: unknown or unsupported inventory version: ValueError('invalid inventory header: ')" looks like an issue with the scipy website (https://docs.scipy.org/ - none of the numpy links resolve) |
Possibly linked to scipy/scipy#15545 @tylerjereddy seems to be dealing with it scipy/scipy#15545 (comment) |
Can we safely say its upstream? Or shall we wait for it to be fixed, re-run then merge. |
Is this PR in a rush to make it to develop? If not I'd say hold until upstream fixes, we don't have any other simple PRs hanging around to check if it's still failing. |
|
sorry - hit close instead of comment for some reason... |
Nah no rush |
Let's give it a day or so - if Tyler comes back and says it's a long term issue then we can either fix or ignore. |
Well, I tried to help fix it upstream, but the intersphinx stuff is tricky. I got a few suggestions, but if we have solid web server/developer folks see: tylerjereddy/htaccess_backup#1 |
The root of the problem is that SciPy has a new docs theme, but it was never tested in a release deployment, so for a while we just didn't publish the release docs b/c of the damage to intersphinx links, but at this point we either try to fix it or we'll never fix it.. |
should have been fixed with #3522, let's see what CI returns like. |
Fixes #3430
Changes made in this Pull Request:
PR Checklist