Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated template asv.conf.json to Python 3.8 #3521

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Feb 7, 2022

Fixes #3430

Changes made in this Pull Request:

PR Checklist

  • n/a Tests?
  • n/a Docs?
  • n/a CHANGELOG updated?
  • Issue raised/referenced?

- fix #3430
- automated benchmarks were updated (see MDAnalysis/benchmarks#11)
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI :)

@orbeckst
Copy link
Member Author

orbeckst commented Feb 7, 2022 via email

@IAlibay
Copy link
Member

IAlibay commented Feb 7, 2022

Cancelling CI and restarting - something off with the docs build, seeing if it's intermittent.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #3521 (215df1b) into develop (01c9dec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3521   +/-   ##
========================================
  Coverage    94.06%   94.06%           
========================================
  Files          176      176           
  Lines        23288    23288           
  Branches      3305     3305           
========================================
  Hits         21905    21905           
  Misses        1337     1337           
  Partials        46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c9dec...215df1b. Read the comment docs.

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

oof something is going wrong with CI... looks like runners are having a field day but gh status is being fine. Hold for re-run in a few hours?

@hmacdope
Copy link
Member

hmacdope commented Feb 8, 2022

re-triggered

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

Still failing on docs - let me check if there's been a recent update to sphinx related things.

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

This seems to be the major difference between the last passing CI run and the current failure:

"intersphinx inventory 'https://docs.scipy.org/doc/numpy/objects.inv' not readable due to ValueError: unknown or unsupported inventory version: ValueError('invalid inventory header: ')"

looks like an issue with the scipy website (https://docs.scipy.org/ - none of the numpy links resolve)

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

Possibly linked to scipy/scipy#15545

@tylerjereddy seems to be dealing with it scipy/scipy#15545 (comment)

@hmacdope
Copy link
Member

hmacdope commented Feb 8, 2022

Can we safely say its upstream? Or shall we wait for it to be fixed, re-run then merge.

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

Can we safely say its upstream? Or shall we wait for it to be fixed, re-run then merge.

Is this PR in a rush to make it to develop? If not I'd say hold until upstream fixes, we don't have any other simple PRs hanging around to check if it's still failing.

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

Can we safely say its upstream? Or shall we wait for it to be fixed, re-run then merge.

Is this PR in a rush to make it to develop? If not I'd say hold until upstream fixes, we don't have any other simple PRs hanging around to check if it's still failing.

@IAlibay IAlibay closed this Feb 8, 2022
@IAlibay IAlibay reopened this Feb 8, 2022
@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

sorry - hit close instead of comment for some reason...

@hmacdope
Copy link
Member

hmacdope commented Feb 8, 2022

Nah no rush

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

Let's give it a day or so - if Tyler comes back and says it's a long term issue then we can either fix or ignore.

@tylerjereddy
Copy link
Member

Well, I tried to help fix it upstream, but the intersphinx stuff is tricky. I got a few suggestions, but if we have solid web server/developer folks see: tylerjereddy/htaccess_backup#1

@tylerjereddy
Copy link
Member

The root of the problem is that SciPy has a new docs theme, but it was never tested in a release deployment, so for a while we just didn't publish the release docs b/c of the damage to intersphinx links, but at this point we either try to fix it or we'll never fix it..

@IAlibay
Copy link
Member

IAlibay commented Feb 8, 2022

should have been fixed with #3522, let's see what CI returns like.

@IAlibay IAlibay merged commit 11d1b7f into develop Feb 8, 2022
@IAlibay IAlibay deleted the update-bench-38 branch February 8, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move benchmarks to > 3.7
4 participants