Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from the TPR parser #3516

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

jbarnoud
Copy link
Contributor

@jbarnoud jbarnoud commented Feb 2, 2022

Fixes #3515

Remove dead code as promised in #3514

PR Checklist

- [ ] Tests?
- [ ] Docs?
- [ ] CHANGELOG updated?

  • Issue raised/referenced?

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I guess the best option is just to remove it - it's too bad since it's quite informative, but at least it's in previous versions so we can mine it from there as needed

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #3516 (af11f42) into develop (e482c39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3516   +/-   ##
========================================
  Coverage    94.06%   94.06%           
========================================
  Files          176      176           
  Lines        23284    23284           
  Branches      3303     3303           
========================================
  Hits         21903    21903           
  Misses        1335     1335           
  Partials        46       46           
Impacted Files Coverage Δ
package/MDAnalysis/topology/TPRParser.py 95.16% <ø> (ø)
package/MDAnalysis/topology/tpr/utils.py 97.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e482c39...af11f42. Read the comment docs.

@IAlibay IAlibay merged commit 7fa06a6 into develop Feb 3, 2022
@IAlibay IAlibay deleted the issue3515-tpr-dead-code branch February 3, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead code in the TPR parser
2 participants