Prevent flush on closed NamedStream #3507
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3507 +/- ##
===========================================
- Coverage 94.06% 94.06% -0.01%
===========================================
Files 176 176
Lines 23282 23284 +2
Branches 3302 3303 +1
===========================================
Hits 21901 21901
- Misses 1335 1337 +2
Partials 46 46
Continue to review full report at Codecov.
|
|
I think codecov is being weird again - not sure why it thinks there's two extra misses. We can add an issue to raise test coverage for lib later? (it's a simple enough GSoC-starter) |
package/MDAnalysis/lib/util.py
Outdated
|
|
||
| .. versionchanged:: 2.1.0 | ||
| Calls to ``close()`` will no longer attempt to close or flush the | ||
| stream if :attr:`closed` is `True`. |
There was a problem hiding this comment.
Won't it get pretty verbose if you start adding versionchanged directives for bug fixes as opposed to select new features or API changes?
There was a problem hiding this comment.
Yeah I can see that. I'm happy to not include that, I'm tempted to remove the entry from the changelog too if you're good with that?
|
Is there anything else than the buggy codecov that prevents this PR from going through? |
|
Mostly forgot about it 😅 I did wonder if anyone else had any strong opinions about what is essentially hiding some of the |
|
Thank you @IAlibay 😄 |
Fixes #3386
Changes made in this Pull Request:
PR Checklist