Fixes issues 3166 and 3255 #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAlibay
commented
May 2, 2021
| @@ -330,6 +330,9 @@ def _get_dt(self): | |||
| t1 = self.ts.time | |||
| dt = t1 - t0 | |||
| except StopIteration: | |||
| msg = ('dt information could not be obtained, defaulting to 0 ps. ' | |||
| 'Note: in MDAnalysis 2.1.0 this default will change 1 ps.') | |||
| warnings.warn(msg) | |||
| return 0 | |||
There was a problem hiding this comment.
This is inconsistent with what we do in base.py, ideally this should just throw an AttributeError and default on what's done in base?
Codecov Report
@@ Coverage Diff @@
## develop #3256 +/- ##
===========================================
+ Coverage 92.85% 92.86% +0.01%
===========================================
Files 170 170
Lines 22840 22845 +5
Branches 3240 3240
===========================================
+ Hits 21208 21215 +7
+ Misses 1584 1582 -2
Partials 48 48
Continue to review full report at Codecov.
|
richardjgowers
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3166 #3255
Changes made in this Pull Request:
dtcalls for netcdf files.PR Checklist