-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2327 - Warn of upcoming scale_factor changes #3185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3185 +/- ##
==========================================
+ Coverage 90.96% 91.81% +0.84%
==========================================
Files 162 167 +5
Lines 22192 22699 +507
Branches 3201 3201
==========================================
+ Hits 20187 20840 +653
- Misses 1382 1775 +393
+ Partials 623 84 -539
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @IAlibay. Is there currently a PR open implementing these changes in 2.0?
Also please can you resolve the CHANGELOG conflict :)
Not yet, I'll deal with it post-1.1.0 release / dealing with our March deadlines 😉 |
I can't seem to squash-merge this on the app (merge seems to be the only option). If anyone else feels like doing it, please feel free! |
Towards MDAnalysis#2327 # Work done in this PR * Adds warning for upcoming changes to scale_factor writing in NCDFWriter
- Fixes #2327 - Completes #3185 - Adds `scale_factor` writing support to NCDFWriter. - Changes the default `scale_factor` value for velocity writing to 20.455 in order to match the AMBER default Co-authored-by: Lily Wang <[email protected]> Co-authored-by: Oliver Beckstein <[email protected]>
Towards #2327
Changes made in this Pull Request:
scale_factor
entries with the NCDFWriter.PR Checklist