-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ParmedConverter taking Timestep objects #3172
Conversation
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-03 18:33:17 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3172 +/- ##
==========================================
+ Coverage 90.96% 91.82% +0.86%
==========================================
Files 162 167 +5
Lines 22196 22702 +506
Branches 3201 3201
==========================================
+ Hits 20191 20847 +656
- Misses 1382 1771 +389
+ Partials 623 84 -539
Continue to review full report at Codecov.
|
5929a64
to
60e7268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor things
fc808d7
to
63fbaae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still gotta live that py2.7 life :(
Fixes #Relates to #3031
Changes made in this Pull Request:
PR Checklist