Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates hbond_autocorrel #3170

Closed
wants to merge 3 commits into from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 15, 2021

Fixes #2987

Changes made in this Pull Request:

  • Deprecates hbond_autocorrel, to be removed in 2.0.0.
  • Also adds missing test for deprecated hbonds.hbond_analysis

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@pep8speaks
Copy link

pep8speaks commented Mar 15, 2021

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 301:80: E501 line too long (80 > 79 characters)

Comment last updated at 2021-03-15 16:51:14 UTC

@IAlibay
Copy link
Member Author

IAlibay commented Mar 15, 2021

Closing based on #2987 (comment)

Will open a separate PR for moving/fixing hbond_autocorrel.

@IAlibay IAlibay closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants