Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds test for issue 2670 [for develop] #3165

Closed
wants to merge 1 commit into from
Closed

Adds test for issue 2670 [for develop] #3165

wants to merge 1 commit into from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 14, 2021

Fixes #2670

Changes made in this Pull Request:

  • Adds the same test being added to master

Note:

  • This should fail at the moment, but it's a good reminder to make sure that we merge the new nsgrid code into develop.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay added this to the 2.0 milestone Mar 14, 2021
@richardjgowers
Copy link
Member

I think because this causes a segfault it won't "fail" but just explode horribly.

@IAlibay
Copy link
Member Author

IAlibay commented Apr 3, 2021

There's been a lot of changes to what's going on in NSGrid, and I'm not sure this is still relevant. I'm going to close this placeholder, let's just remember to make sure we forwardport the NSGrid fixes.

@IAlibay IAlibay closed this Apr 3, 2021
@IAlibay IAlibay deleted the issue-2670-develop branch April 3, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

capped distance fails for very small (<0.1A) boxes
2 participants
@IAlibay @richardjgowers