Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test to make sure small box issue is now fixed #2670 #3163

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 14, 2021

Fixes #2670

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay requested a review from richardjgowers March 14, 2021 21:01
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #3163 (9fd5e05) into master (7ed893d) will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
+ Coverage   90.97%   91.81%   +0.84%     
==========================================
  Files         162      167       +5     
  Lines       22194    22699     +505     
  Branches     3198     3198              
==========================================
+ Hits        20190    20841     +651     
- Misses       1381     1774     +393     
+ Partials      623       84     -539     
Impacted Files Coverage Δ
package/MDAnalysis/topology/tpr/obj.py 96.82% <0.00%> (-3.18%) ⬇️
...onality_reduction/DimensionalityReductionMethod.py 97.14% <0.00%> (-2.86%) ⬇️
package/MDAnalysis/due.py 56.09% <0.00%> (ø)
package/MDAnalysis/analysis/legacy/x3dna.py 0.00% <0.00%> (ø)
package/MDAnalysis/analysis/legacy/__init__.py 0.00% <0.00%> (ø)
package/MDAnalysis/tests/__init__.py 100.00% <0.00%> (ø)
package/MDAnalysis/tests/datafiles.py 31.25% <0.00%> (ø)
package/MDAnalysis/core/selection.py 99.52% <0.00%> (+<0.01%) ⬆️
...sis/analysis/encore/clustering/ClusteringMethod.py 96.96% <0.00%> (+0.04%) ⬆️
package/MDAnalysis/analysis/base.py 95.60% <0.00%> (+0.04%) ⬆️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed893d...9fd5e05. Read the comment docs.

@IAlibay IAlibay merged commit 2c9be4e into MDAnalysis:master Mar 14, 2021
@IAlibay IAlibay deleted the issue-2670 branch March 14, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants