-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try StringIO in test_PDB_metals #3081
Conversation
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-12-19 22:41:26 UTC |
Codecov Report
@@ Coverage Diff @@
## develop #3081 +/- ##
========================================
Coverage 93.17% 93.17%
========================================
Files 171 171
Lines 22729 22729
Branches 3216 3216
========================================
Hits 21177 21177
Misses 1504 1504
Partials 48 48 Continue to review full report at Codecov.
|
Well, this worked. 🤷♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is all green so I'm going to put it in. Strictly speaking we may not need the switch to StringIO
but doesn't seem worth the turnover to revert it either.
thanks @lilyminium |
Fixes #3080
Changes made in this Pull Request:
PR Checklist