Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try StringIO in test_PDB_metals #3081

Merged
merged 4 commits into from
Dec 20, 2020
Merged

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented Dec 18, 2020

Fixes #3080

Changes made in this Pull Request:

  • Try StringIO instead of actual file

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@pep8speaks
Copy link

pep8speaks commented Dec 18, 2020

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-19 22:41:26 UTC

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #3081 (7a7885f) into develop (2223363) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3081   +/-   ##
========================================
  Coverage    93.17%   93.17%           
========================================
  Files          171      171           
  Lines        22729    22729           
  Branches      3216     3216           
========================================
  Hits         21177    21177           
  Misses        1504     1504           
  Partials        48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2223363...7a7885f. Read the comment docs.

@lilyminium
Copy link
Member Author

lilyminium commented Dec 18, 2020

Well, this worked. 🤷‍♀️

@lilyminium lilyminium changed the title [WIP] Try StringIO in test_PDB_metals Try StringIO in test_PDB_metals Dec 18, 2020
@lilyminium lilyminium closed this Dec 19, 2020
@lilyminium lilyminium reopened this Dec 19, 2020
@lilyminium lilyminium closed this Dec 19, 2020
@lilyminium lilyminium reopened this Dec 19, 2020
Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is all green so I'm going to put it in. Strictly speaking we may not need the switch to StringIO but doesn't seem worth the turnover to revert it either.

@tylerjereddy tylerjereddy merged commit c4c121e into MDAnalysis:develop Dec 20, 2020
@tylerjereddy
Copy link
Member

thanks @lilyminium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure py3.8 test failure
4 participants