-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParmEdConverter: fix NameError when catching NoDataError #2953
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2953 +/- ##
===========================================
+ Coverage 93.05% 93.09% +0.03%
===========================================
Files 186 186
Lines 24613 24663 +50
Branches 3187 3197 +10
===========================================
+ Hits 22904 22959 +55
+ Misses 1661 1656 -5
Partials 48 48
Continue to review full report at Codecov.
|
Oops, thanks for finding this. Could you please add a test as well so the tests will catch it in the future as well? |
You don't need to update the CHANGELOG as this just fixes something that hadn't been released yet. (We don't absolutely strictly adhere to what I just said because our release cycles are so stretched out that we need to track bugs in develop and often fix issues that never show up in a released version. But in the case here a CHANGELOG entry seems overkill.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test?
Not for testing that your fix worked but rather because it indicates that we didn't test a possible (and perhaps not uncommon) failure mode earlier.
Sorry for the delay and the messed up commits, should be fixed now |
Thank you! |
…2953) * fix NameError when catching NoDataError * add test + missing imports
…2953) * fix NameError when catching NoDataError * add test + missing imports
…2953) * fix NameError when catching NoDataError * add test + missing imports
Converting to parmed when the AtomGroup doesn't have a resname leads to a NameError: the current code tries to catch the NoDataError but because NoDataError is not imported from exceptions.py it triggers a
NameError: name 'NoDataError' is not defined
Changes made in this Pull Request:
Is the changelog update needed here ?
PR Checklist