-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NUMBER_TO_ELEMENTS
#2700
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2700 +/- ##
===========================================
- Coverage 91.15% 91.12% -0.03%
===========================================
Files 175 174 -1
Lines 23719 23650 -69
Branches 3104 3104
===========================================
- Hits 21620 21551 -69
Misses 1480 1480
Partials 619 619
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make the CHANGELOG message more informative but overall LGTM.
Fixes #2699
Changes made in this Pull Request:
NUMBER_TO_ELEMENTS
toZ2SYMB
in TOPParserAdditional context:
Unfortunately it seems I tackled this the wrong way around. The elements testing for TOPParser is a little bit all over the place at the moment, but I plan to more thoroughly change things with #2651, if anything, the
test_elements
function for PRM12 is going to get moved to TOPBase.PR Checklist