Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NUMBER_TO_ELEMENTS #2700

Merged
merged 7 commits into from
May 28, 2020
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented May 27, 2020

Fixes #2699

Changes made in this Pull Request:

Additional context:

Unfortunately it seems I tackled this the wrong way around. The elements testing for TOPParser is a little bit all over the place at the moment, but I plan to more thoroughly change things with #2651, if anything, the test_elements function for PRM12 is going to get moved to TOPBase.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #2700 into develop will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2700      +/-   ##
===========================================
- Coverage    91.15%   91.12%   -0.03%     
===========================================
  Files          175      174       -1     
  Lines        23719    23650      -69     
  Branches      3104     3104              
===========================================
- Hits         21620    21551      -69     
  Misses        1480     1480              
  Partials       619      619              
Impacted Files Coverage Δ
package/MDAnalysis/topology/tables.py 100.00% <ø> (ø)
package/MDAnalysis/topology/TOPParser.py 100.00% <100.00%> (ø)
auxiliary/base.py 90.84% <0.00%> (-0.56%) ⬇️
coordinates/base.py 94.67% <0.00%> (-0.29%) ⬇️
util.py 88.19% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55afb4c...4019011. Read the comment docs.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make the CHANGELOG message more informative but overall LGTM.

package/CHANGELOG Outdated Show resolved Hide resolved
@orbeckst orbeckst self-assigned this May 28, 2020
@orbeckst orbeckst merged commit 57e7bd4 into MDAnalysis:develop May 28, 2020
@IAlibay IAlibay deleted the remove-numtoelem branch May 28, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove _elements.py (NUMBER_TO_ELEMENT)
3 participants