Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap up loose ends from PR review #2633

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

wvdtoorn
Copy link
Contributor

Fixes #2537

Changes made in this Pull Request:

  • Two small formatting and grammar fixes

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #2633 into densityanalysis-2502 will increase coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           densityanalysis-2502    #2633      +/-   ##
========================================================
+ Coverage                 91.01%   91.85%   +0.83%     
========================================================
  Files                       174       15     -159     
  Lines                     23601     2013   -21588     
  Branches                   3075        0    -3075     
========================================================
- Hits                      21480     1849   -19631     
+ Misses                     1498      164    -1334     
+ Partials                    623        0     -623
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/GRO.py
package/MDAnalysis/coordinates/base.py
package/MDAnalysis/analysis/helanal.py
package/MDAnalysis/topology/MinimalParser.py
package/MDAnalysis/visualization/__init__.py
...e/MDAnalysis/analysis/encore/clustering/cluster.py
package/MDAnalysis/coordinates/DCD.py
package/MDAnalysis/coordinates/GSD.py
package/MDAnalysis/coordinates/memory.py
package/MDAnalysis/exceptions.py
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cfdec6...faf2651. Read the comment docs.

@richardjgowers richardjgowers merged commit 1bfb9a8 into MDAnalysis:densityanalysis-2502 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants