Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TRJReader random frame access docs #2595

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 8, 2020

Fixes #2398

Changes made in this Pull Request:

  • Removes outdated TRJReader documentation on random frame access

I was going to include this as part of larger PR, but I keep stalling on it, so here's a micro-commit 😅 (sorry)

PR Checklist

  • Tests? (random access was already tested for)
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay requested a review from lilyminium March 8, 2020 20:34
Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this @IAlibay!

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #2595 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2595   +/-   ##
========================================
  Coverage    90.57%   90.57%           
========================================
  Files          173      173           
  Lines        23383    23383           
  Branches      3038     3038           
========================================
  Hits         21180    21180           
  Misses        1585     1585           
  Partials       618      618           
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/TRJ.py 95.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e0d6d...b43dd54. Read the comment docs.

@richardjgowers richardjgowers merged commit 9581bc4 into MDAnalysis:develop Mar 9, 2020
@IAlibay IAlibay deleted the trj-changes branch June 6, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated documentation for AMBER TRJReader
4 participants