-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2582: polymer persistence length example fix #2589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
- Please add the issue number polymer persistence length example fails #2582 in the "Fix #" line of your issue so that PR and issue are linked.
- Did you run the example? Can you please show some evidence that this works, e.g., run in a jupyter notebook and show a screenshot of the executed code and the resulting plot. (Normally we would have tests but the doc examples are not explicitly tested)
Thanks.
Codecov Report
@@ Coverage Diff @@
## develop #2589 +/- ##
========================================
Coverage 90.57% 90.57%
========================================
Files 173 173
Lines 23383 23383
Branches 3038 3038
========================================
Hits 21180 21180
Misses 1585 1585
Partials 618 618 Continue to review full report at Codecov.
|
@orbeckst is this fine? |
This is looking good. Can you show the plot to? plt.savefig("persistence.jpg") and attach as a comment. |
Why are there multiple plots? Perhaps do |
Looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done. As you are new contributor to the code base:
- add yourself to AUTHORS
- add an entry "fixed example docs for polymer persistence length (polymer persistence length example fails #2582)" under Fixes to CHANGELOG (and don't forget to add your GitHub handle to author list for the next release)
Added name to AUTHOR file
@orbeckst I couldn't figure out how to add my github handle to author list. |
c0956e7
to
6226217
Compare
Have a look at what @richardjgowers did for you do you know how to do it in the future. |
Yes i do understand it |
@ss62171 congratulations on your first contribution! Thank you! |
It was really fun to work on this :) |
Fixes #2582
Changes made in this Pull Request:
lp variable is renamed to persistence length and missing * is added after H
'not name O* H'
.PR Checklist